Skip to content

added path.absolute check#10171

Merged
christian-bromann merged 1 commit intomainfrom
innerfolder-praveen
Apr 11, 2023
Merged

added path.absolute check#10171
christian-bromann merged 1 commit intomainfrom
innerfolder-praveen

Conversation

@praveendvd
Copy link
Contributor

Proposed changes

fix for #10127

added check whether the path is absolute before concatinating with cwd

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much better 👌

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Apr 11, 2023
@christian-bromann christian-bromann merged commit e6d503f into main Apr 11, 2023
@christian-bromann christian-bromann deleted the innerfolder-praveen branch April 11, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants