Skip to content

Have better internal API for shared store#10121

Merged
christian-bromann merged 1 commit intomainfrom
cb-better-shared-store-api
Apr 5, 2023
Merged

Have better internal API for shared store#10121
christian-bromann merged 1 commit intomainfrom
cb-better-shared-store-api

Conversation

@christian-bromann
Copy link
Member

Proposed changes

After #10029 was merged I realised it would be nice to have a better API interface for the shared store service. Even though it is an internal API that users don't interact with it will make code more and better to read if we stay compliant with common API design patterns.

Types of changes

  • Polish (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann requested a review from a team April 5, 2023 18:21
@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Apr 5, 2023
@christian-bromann christian-bromann merged commit c0570b8 into main Apr 5, 2023
@christian-bromann christian-bromann deleted the cb-better-shared-store-api branch April 5, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant