Skip to content

Expand type of otherApps capability #10081

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
gjhughes:fix-otherApps-type
Mar 29, 2023
Merged

Expand type of otherApps capability #10081
christian-bromann merged 1 commit intowebdriverio:mainfrom
gjhughes:fix-otherApps-type

Conversation

@gjhughes
Copy link
Contributor

@gjhughes gjhughes commented Mar 28, 2023

Proposed changes

Appium allows otherApps to be either a string or an array of strings. When running tests on Browserstack, otherApps has to be passed as an array.

Currently this causes a type error:

wdio.remote({ capabilities: {'appium:otherApps': ["/path/to/app"]} })`

but passing a string with Browserstack results in an error:

https://www.browserstack.com/question/39479

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 28, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: gjhughes / name: Gavin Hughes (e090fd3)

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

Congrats on your first WebdriverIO contribution 🎉

@christian-bromann christian-bromann merged commit 9f6d24b into webdriverio:main Mar 29, 2023
@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants