Conversation
christian-bromann
left a comment
There was a problem hiding this comment.
@epszaw is there a way to set these information without setting a private property?
Yes. If you talk about unit tests, it's possible to use |
|
@BorisOsipov made the changes thank you so much could you have a look |
| import { | ||
| TYPE as DescriptionType | ||
| } from './types.js' | ||
| import { md5 } from 'allure-js-commons' |
There was a problem hiding this comment.
We already import allure-js-commons at the top, so let's add md5 to it.
|
@praveendvd Looks good. It seems that it would be nice to add unit tests for these changes to avoid any potential regressions. |
There was a problem hiding this comment.
I would love to include this into the next release so I will go ahead and merge it.
Thanks @praveendvd for the fix 👍
It seems that it would be nice to add unit tests for these changes to avoid any potential regressions.
I will add unit tests for it.
Proposed changes
Allure checks if a test case is unique by using history and testcaseid , so exiplicitly added cid as these ids
fix for #9993
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers