Skip to content

[🐛 Bug]: Selecting Lit as framework when selecting browser runner does not create example files for Lit#10047

Merged
christian-bromann merged 1 commit intomainfrom
cb-tpl-lit-fix
Apr 5, 2023
Merged

[🐛 Bug]: Selecting Lit as framework when selecting browser runner does not create example files for Lit#10047
christian-bromann merged 1 commit intomainfrom
cb-tpl-lit-fix

Conversation

@christian-bromann
Copy link
Member

Have you read the Contributing Guidelines on issues?

WebdriverIO Version

latest

Node.js Version

latest

Mode

WDIO Testrunner

Which capabilities are you using?

n/a

What happened?

The browser runner generates example files for every framework if the user desires that. However when selecting Lit, no Lit component is generated. This is a bug in the @wdio/cli package as we use the SUPPORTED_BROWSER_RUNNER_PRESETS constant to determine if an example component for a framework should be generated and something goes wrong here given lit has the same value as Other.

What is your expected behavior?

Proper example component is created for Lit.

How to reproduce the bug.

Just run npm init wdio@latest ./ and select browser runner, Lit as framework and press yes when the wizard asks for generating example files.

Relevant log output

n/a

Code of Conduct

  • I agree to follow this project's Code of Conduct

Is there an existing issue for this?

  • I have searched the existing issues

@christian-bromann christian-bromann added Bug 🐛 help wanted Issues that are free to take by anyone interested good first pick a reasonable task to start getting familiar with the code base labels Mar 25, 2023
@christian-bromann christian-bromann added PR: Bug Fix 🐛 PRs that contain bug fixes and removed Bug 🐛 help wanted Issues that are free to take by anyone interested good first pick a reasonable task to start getting familiar with the code base labels Apr 5, 2023
@christian-bromann christian-bromann merged commit 1ec48d2 into main Apr 5, 2023
@christian-bromann christian-bromann deleted the cb-tpl-lit-fix branch April 5, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant