Skip to content

Fix handling existence checks for shadow elements#10045

Merged
christian-bromann merged 4 commits intomainfrom
cb-shadow-element-fix
Mar 27, 2023
Merged

Fix handling existence checks for shadow elements#10045
christian-bromann merged 4 commits intomainfrom
cb-shadow-element-fix

Conversation

@christian-bromann
Copy link
Member

Proposed changes

fixes #10043

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

missing: tests

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Mar 24, 2023
@christian-bromann christian-bromann requested a review from a team March 24, 2023 15:55
@christian-bromann christian-bromann merged commit b39d082 into main Mar 27, 2023
@christian-bromann christian-bromann deleted the cb-shadow-element-fix branch March 27, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: New shadow command doesn't work

1 participant