Conversation
b16e802 to
4660f44
Compare
- Upgrade to Jackson3 - Now ObjectConverter constructor takes JsonMapper and CBORMapper as parameters instead of ObjectMapper - JacksonUtil no longer wraps IOException with UncheckedIOException as Jackson no longer returns IOException - JsonConverter and CborConverter no longer wraps IOException with UncheckedIOEception as jackson no longer returns IOException
924183c to
9f940b0
Compare
The JsonConverter and CborConverter were thin wrappers around ObjectMapper and wrapped checked exceptions into unchecked ones. They also specified at the type level whether it was a JSON or CBOR converter. However, since Jackson 3 introduced JsonMapper and CborMapper and they no longer throw checked exceptions, JsonConverter and CborConverter have been deprecated. Please note that when switching from JsonConverter to JsonMapper or from CborConverter to CborMapper, exceptions will no longer be wrapped in a DataConversionException.
to align with Jackson3 default
to align with Jackson3 default and removed failing test cases. These test cases were originally added to verify that IOExceptions would be wrapped when they occurred, but since IOExceptions no longer occur, they have become unnecessary.
to align jackson default
This was
linked to
issues
Jan 2, 2026
Closed
|
📦 JitPack BuildThe build and tests passed! You can test this Pull Request using JitPack. Maven<repositories>
<repository>
<id>jitpack.io</id>
<url>https://jitpack.io</url>
</repository>
</repositories>
<dependency>
<groupId>com.github.webauthn4j.webauthn4j</groupId>
<artifactId>webauthn4j-core</artifactId>
<version>jackson3-SNAPSHOT</version>
</dependency>Gradlerepositories {
maven { url 'https://jitpack.io' }
}
dependencies {
implementation 'com.github.webauthn4j.webauthn4j:webauthn4j-core:jackson3-SNAPSHOT'
}You can verify the build status on JitPack. |
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonMapperandCBORMapper(introduced in Jackson 3) instead ofObjectMapperfor JSON andObjectMapperfor CBORJsonConverterandCborConverterreturned byObjectConverter#getJsonConverter()andObjectConverter#getCborConverter()have been deprecated and will be removed in the futureJsonMapperandCBORMapperin Jackson 3 no longer throw checked exceptions, these wrappers are now obsoleteJsonMapperandCBORMapperinstances returned byObjectConverter#getJsonMapper()andObjectConverter#getCborMapper(), which are configured for WebAuthn data structure serialization/deserializationJsonConverterandCborConverter, exceptions will no longer be wrapped inDataConversionExceptionwhen usingJsonMapperorCBORMapperdirectlyDeserializationFeature.FAIL_ON_TRAILING_TOKENSoption has been enabledSerializationFeature.FAIL_ON_EMPTY_BEANSoption has been enabledDeserializationFeature.WRAP_EXCEPTIONSoption has been enabledJacksonUtilno longer wrapsIOExceptionwithUncheckedIOExceptionas Jackson no longer throwsIOException