fix(e2e): skip headed browser tests on Linux CI without display#999
Merged
fix(e2e): skip headed browser tests on Linux CI without display#999
Conversation
viewport.test.ts and locatorApi.test.ts have test cases that pass `--browser.headless false`, forcing headed mode. These fail on Linux CI (e.g. ecosystem-ci on Ubuntu) because there is no X Server / $DISPLAY. Gate these tests with the existing `canRunHeadedBrowser` check so they are automatically skipped when no display server is available. Amp-Thread-ID: https://ampcode.com/threads/T-019cb6d2-2de7-757d-8fb6-e47e3c4fbd93 Co-authored-by: Amp <amp@ampcode.com>
9aoy
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
viewport.test.tsandlocatorApi.test.tshave test cases that pass--browser.headless false, forcing headed mode. These fail on Linux CI (e.g. ecosystem-ci on Ubuntu) because there is no X Server /$DISPLAY.Fix
Gate the headed-mode test cases with the existing
canRunHeadedBrowsercheck frome2e/browser-mode/utils.ts, so they are automatically skipped when no display server is available (Linux withoutDISPLAY/WAYLAND_DISPLAY). macOS and Windows are unaffected.Changes
e2e/browser-mode/viewport.test.ts:it.skipIf(!canRunHeadedBrowser)on the headed test casee2e/browser-mode/locatorApi.test.ts:it.skipIf(!canRunHeadedBrowser)on the headed test case