test(browser-mode): guard headed e2e case by display availability#958
Merged
test(browser-mode): guard headed e2e case by display availability#958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to prevent fail like https://github.com/web-infra-dev/rspack/actions/runs/21852746524/job/63063200058.
This PR stabilizes browser-mode e2e execution by conditionally running the headed test only when the environment can actually launch a headed browser. It preserves the original headed-path assertion on macOS, Windows, and display-enabled Linux, while avoiding false negatives on Linux runners without X/Wayland display variables.
Behavior diff:
Related Links
Checklist