fix(core): include worker stderr in unexpected-exit summary#956
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c81424e36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3c81424 to
ed571e1
Compare
9aoy
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supersede #949.
This PR fixes missing diagnostics when a child worker crashes (for example, rspack panic) under tinypool
child_processmode. It captures workerstderrat the pool layer, binds output to the active task via worker meta messages, and appends relevant logs to the summary error. The implementation avoids renderer/globalstderrmonkey-patching and adds e2e coverage for the crash path.Behavior diff:
Changes:
packages/core/src/pool/stderrCapture.tswith ring buffer, truncation, close-wait timeoutpackages/core/src/pool/workerMeta.ts; worker emits meta inpackages/core/src/runtime/worker/index.tspackages/core/src/pool/forks.tsparses worker meta and appends captured stderr on unexpected worker exite2e/worker/fixtures/worker.panic.test.tsand assertions ine2e/worker/index.test.tsRelated Links
Checklist