test: drop browser mode test from no-isolate test#944
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR excludes browser mode tests from the no-isolate test run since browser mode uses iframe-based isolation, which is unrelated to Node.js worker isolation controlled by the --isolate false flag.
Changes:
- Added
browser-mode/**to the list of directories excluded when running tests in no-isolate mode - Refactored the inline exclusion array into a well-documented constant
NO_ISOLATE_EXCLUDES - Added clear documentation explaining why each directory (watch, mock, browser-mode) is excluded from no-isolate testing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drop browser mode test from no-isolate test since it's totally non related.
Related Links
Checklist