test(e2e): unify timeout time, less flaky#942
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR unifies the E2E test timeout configuration by removing individual test-specific timeout values and relying on the centralized configuration in e2e/rstest.config.ts, which provides 60 seconds for CI environments and 10 seconds for local development.
Changes:
- Removed custom timeout values from Vue SFC and JSX tests (previously 20 seconds)
- Removed custom timeout values from project sharding tests (previously 30 seconds)
- Removed custom timeout value from a project test (previously 15 seconds)
- Removed custom timeout values from project coverage tests (previously 60 seconds)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/vue/sfc.test.ts | Removed 20-second custom timeout and "fix timeout in CI" comment, now uses unified timeout |
| e2e/vue/jsx.test.ts | Removed 20-second custom timeout, now uses unified timeout |
| e2e/projects/shard.test.ts | Removed 30-second custom timeouts from two shard tests, now uses unified timeout |
| e2e/projects/index.test.ts | Removed 15-second custom timeout, now uses unified timeout |
| e2e/projects/coverage.test.ts | Removed 60-second custom timeouts from two coverage tests, now uses unified timeout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use the unified timeout config for E2E test, less flaky, and only reserve the case specific timeout for timeout related cases.
Related Links
Checklist