Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the browser watch-mode e2e tests so that their temporary fixture directories live alongside, rather than inside, the shared fixtures/ directory to avoid cross-test race conditions when tests run in parallel.
Changes:
- Updated
fixturesTargetPathinbrowser-mode/watch.test.tsto use${__dirname}/fixtures-test-browser-watch-sourceand${__dirname}/fixtures-test-browser-watch, moving them out of thefixtures/folder. - Left the underlying fixture source path (
fixturesPath: ${__dirname}/fixtures/watch) unchanged so the same fixture content is copied into the new, sibling temp directories.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eeac60e to
300dcba
Compare
300dcba to
dc39dd8
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixtures/folder to avoid race condition when tests run in parallelProblem
The
browser-mode/watch.test.tscreated temp directories insidefixtures/:fixtures/fixtures-test-browser-watchfixtures/fixtures-test-browser-watch-sourceWhen
snapshot.test.tsruns in parallel, itsprepareFixturescopies the entirefixtures/directory. If the watch test deletesits temp directory during this copy operation, it causes
ENOENTerrors.Solution
Change paths from:
${__dirname}/fixtures/fixtures-test-browser-watchTo:
${__dirname}/fixtures-test-browser-watchThis matches the pattern used by all other e2e tests.
Related Links
Checklist