fix: should respect project's slowTestThreshold configuration#938
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enables project-specific configuration overrides for slowTestThreshold, hideSkippedTests, and hideSkippedTestFiles in a multi-project testing setup. Previously, these configurations could only be set globally; now each project can have its own settings that override the global defaults.
Changes:
- Modified type definitions to allow
hideSkippedTestsandhideSkippedTestFilesin project configurations - Updated DefaultReporter and VerboseReporter to respect per-project settings with proper fallback to global config
- Added projectConfigs map infrastructure to pass project configurations to reporters
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/types/config.ts | Removed hideSkippedTests and hideSkippedTestFiles from ProjectConfig exclusion list to allow per-project configuration |
| packages/core/src/reporter/verbose.ts | Added projectConfigs parameter and logic to retrieve project-specific settings for hideSkippedTestFiles, slowTestThreshold, and hideSkippedTests |
| packages/core/src/reporter/index.ts | Added projectConfigs parameter and logic to retrieve project-specific settings with fallback to global config |
| packages/core/src/core/rstest.ts | Created projectConfigs map keyed by project name and passed it to reporter initialization |
| e2e/projects/index.test.ts | Added comprehensive E2E tests for hideSkippedTests, slowTestThreshold, and hideSkippedTestFiles per-project configurations |
| e2e/projects/fixtures/rstest.slowTest.config.ts | Test configuration demonstrating different slowTestThreshold values per project |
| e2e/projects/fixtures/rstest.projectConfig.config.ts | Test configuration demonstrating different hideSkippedTests values per project |
| e2e/projects/fixtures/rstest.hideSkippedTestFiles.config.ts | Test configuration demonstrating different hideSkippedTestFiles values per project |
| e2e/projects/fixtures/packages/node/test/slow.test.ts | Test file with async delay to test slowTestThreshold behavior |
| e2e/projects/fixtures/packages/node/test/skip.test.ts | Test file with skipped test to verify hideSkippedTests behavior |
| e2e/projects/fixtures/packages/node/test/allSkipped.test.ts | Test file with all tests skipped to verify hideSkippedTestFiles behavior |
| e2e/projects/fixtures/packages/client/test/slow.test.ts | Client-side slow test for cross-project slowTestThreshold testing |
| e2e/projects/fixtures/packages/client/test/skip.test.ts | Client-side skip test for cross-project hideSkippedTests testing |
| e2e/projects/fixtures/packages/client/test/allSkipped.test.ts | Client-side all-skipped test for cross-project hideSkippedTestFiles testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slowTestThreshold configurationslowTestThreshold configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
should respect project's
slowTestThreshold/hideSkippedTests/hideSkippedTestFilesconfigurationsRelated Links
Checklist