Conversation
There was a problem hiding this comment.
Pull request overview
Updates Rsbuild to 1.7.3 across the monorepo and changes several @rsbuild/core references from pinned versions to a caret range to allow future 1.x updates.
Changes:
- Bump
@rsbuild/corefrom1.7.2to^1.7.3in multiple workspace packages and examples/fixtures. - Refresh
pnpm-lock.yamlto resolve updated Rsbuild/Rspack dependency graph (and related tooling transitive updates). - Bump
@rslib/coreused by thee2eworkspace to0.19.4.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Lockfile refresh for rsbuild/rspack (+ related transitive dependency metadata changes). |
| packages/vscode/package.json | Unpin @rsbuild/core to ^1.7.3 for the VS Code extension workspace. |
| packages/core/package.json | Unpin runtime dependency @rsbuild/core to ^1.7.3. |
| packages/browser-ui/package.json | Unpin @rsbuild/core to ^1.7.3 for browser UI build tooling. |
| packages/adapter-rsbuild/package.json | Unpin adapter dev @rsbuild/core to ^1.7.3. |
| examples/vue/package.json | Unpin @rsbuild/core to ^1.7.3 for Vue example. |
| examples/react/package.json | Unpin @rsbuild/core to ^1.7.3 for React example. |
| examples/react-rsbuild/package.json | Unpin @rsbuild/core to ^1.7.3 for React+adapter example. |
| e2e/vue/fixtures/package.json | Unpin @rsbuild/core to ^1.7.3 in Vue e2e fixture. |
| e2e/projects/fixtures/packages/client/package.json | Unpin @rsbuild/core to ^1.7.3 in React client fixture. |
| e2e/projects/fixtures/packages/client-vue/package.json | Unpin @rsbuild/core to ^1.7.3 in Vue client fixture. |
| e2e/package.json | Unpin @rsbuild/core to ^1.7.3 and bump pinned @rslib/core to 0.19.4. |
| e2e/dom/fixtures/package.json | Unpin @rsbuild/core to ^1.7.3 in DOM fixture. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@rsbuild/core": "^1.7.3", | ||
| "@rslib/core": "0.19.4", | ||
| "@rsbuild/plugin-react": "^1.4.2", |
There was a problem hiding this comment.
PR description/title focus on rsbuild, but this change also bumps @rslib/core (0.19.0 → 0.19.4). Please update the PR description (or split into a separate PR) so reviewers/releasers can track the additional dependency update explicitly.
pnpm-lock.yaml
Outdated
| glob@11.0.3: | ||
| resolution: {integrity: sha512-2Nim7dha1KVkaiF4q6Dj+ngPPMdfvLJEOpZk/jKiUAkqKebpGAWQXAq9z1xu9HKu5lWfqw/FASuccEjyznjPaA==} | ||
| engines: {node: 20 || >=22} | ||
| deprecated: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me | ||
| hasBin: true |
There was a problem hiding this comment.
glob@11.0.3 declares engines: {node: 20 || >=22} but the repo engine range is node: >=18.12.0 (package.json:56-59). Because @vscode/vsce depends on glob@11, running VS Code extension packaging tasks on Node 18 will likely fail; either bump the repo’s supported Node version, or pin/upgrade @vscode/vsce to a Node-18-compatible dependency chain.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Summary
bump rsbuild v1.7.3、 rslib v0.19.4 & unpin rsbuild 1.x.
Related Links
Checklist