Skip to content

fix(reporter): create jUnit output dir tree if needed#927

Merged
9aoy merged 3 commits intoweb-infra-dev:mainfrom
joshuapetryk:fix/junit-nested-output
Feb 2, 2026
Merged

fix(reporter): create jUnit output dir tree if needed#927
9aoy merged 3 commits intoweb-infra-dev:mainfrom
joshuapetryk:fix/junit-nested-output

Conversation

@joshuapetryk
Copy link
Copy Markdown
Contributor

@joshuapetryk joshuapetryk commented Jan 30, 2026

Summary

Current behavior: junit report file will not be created unless the directory specified in outputPath already exists.
This PR changes the behavior so rstest creates the directory structure before writing the file.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 30, 2026

Summary of Changes

Hello @joshuapetryk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where JUnit reports would fail to be generated if their specified output directory did not exist. By integrating directory creation logic, the system now robustly ensures that the target path for JUnit XML reports is prepared before attempting to write the file, enhancing the reliability of report generation.

Highlights

  • Automatic Directory Creation: The JUnit reporter now automatically creates the necessary output directory structure if it doesn't already exist, preventing errors when writing report files.
  • Module Imports: Introduced fs and path modules from Node.js for robust file system operations and path manipulation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly identifies the need to create the output directory for JUnit reports. However, the implementation can be improved. The error handling for directory creation is redundant for modern Node.js versions and could lead to unhandled exceptions for other filesystem errors. I've provided a suggestion to refactor the code to use a single try...catch block for both directory and file creation, which simplifies the logic and makes error handling more robust and consistent with the existing code.

Joshua Petryk added 2 commits January 30, 2026 15:33
@9aoy 9aoy changed the title Create jUnit output dir tree if needed fix(reporter): create jUnit output dir tree if needed Feb 2, 2026
@9aoy 9aoy merged commit 5fe1d27 into web-infra-dev:main Feb 2, 2026
16 of 18 checks passed
@9aoy
Copy link
Copy Markdown
Collaborator

9aoy commented Feb 2, 2026

thanks~

@fi3ework fi3ework mentioned this pull request Feb 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

change: fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshuapetryk @9aoy