Skip to content

fix(coverage): only apply coverage plugin for main js rule#925

Merged
fi3ework merged 2 commits intomainfrom
coverage-include
Jan 30, 2026
Merged

fix(coverage): only apply coverage plugin for main js rule#925
fi3ework merged 2 commits intomainfrom
coverage-include

Conversation

@9aoy
Copy link
Copy Markdown
Collaborator

@9aoy 9aoy commented Jan 30, 2026

Summary

fix(coverage): only apply coverage plugin for main js rule.

should not apply coverage plugin for virtual modules.

image

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 30, 2026

Summary of Changes

Hello @9aoy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the coverage plugin was being applied to virtual modules, leading to incorrect coverage reporting. By refining the plugin's application to target only the main JavaScript rule within the bundler chain, it ensures accurate and intended code coverage. A new end-to-end test has been introduced to confirm the fix and validate coverage collection under various configurations.

Highlights

  • Coverage Plugin Application Refinement: The SWC coverage instrument plugin's application has been refactored. It is now applied specifically to the main JavaScript rule within the bundler chain, rather than broadly through environment configuration. This change prevents the plugin from being incorrectly applied to virtual modules.
  • Prevention of Virtual Module Coverage: This update directly addresses an issue where the coverage plugin was inadvertently processing virtual modules, leading to inaccurate or unintended coverage results. The targeted application ensures only relevant code is instrumented.
  • New End-to-End Test Case: A new end-to-end test has been added to validate that coverage data is collected successfully even when the configuration does not explicitly specify an include option. This enhances the robustness of coverage reporting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@9aoy 9aoy requested a review from fi3ework January 30, 2026 09:08
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors how the coverage plugin is applied by scoping it to the main JavaScript rule, which should fix the issue of it being applied to virtual modules. The new tests are a good addition to verify the behavior. I've made one suggestion to improve the robustness of the implementation in packages/coverage-istanbul/src/plugin.ts to prevent a potential runtime error.

@9aoy @gemini-code-assist
Apply suggestion from @gemini-code-assist[bot]
1060814 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@fi3ework fi3ework merged commit 9fe38b2 into main Jan 30, 2026
9 checks passed
@fi3ework fi3ework deleted the coverage-include branch January 30, 2026 09:40
@fi3ework fi3ework mentioned this pull request Feb 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fi3ework fi3ework fi3ework approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

change: fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@9aoy @fi3ework