feat(core): support pool shorthand and granular CLI options#904
Conversation
Deploying rstest with
|
| Latest commit: |
e2ae4f1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2141643c.rstest.pages.dev |
| Branch Preview URL: | https://ppool.rstest.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds improved pool configuration ergonomics by introducing a --pool <type> shorthand plus granular --pool.* CLI flags, along with corresponding config merge behavior, docs updates, and an E2E smoke test.
Changes:
- Add
--pool <type>shorthand and granular--pool.type/maxWorkers/minWorkers/execArgvCLI options. - Update CLI→config merge logic to normalize/merge
poolcorrectly (including repeatable--pool.execArgv). - Update EN/ZH docs for CLI + pool config, and add an E2E test for the shorthand flag.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/guide/basic/cli.mdx | Documents new --pool shorthand and granular --pool.* flags (ZH). |
| website/docs/zh/config/test/pool.mdx | Updates pool type/docs and adds config shorthand example (ZH). |
| website/docs/en/guide/basic/cli.mdx | Documents new --pool shorthand and granular --pool.* flags (EN). |
| website/docs/en/config/test/pool.mdx | Updates pool type/docs and adds config shorthand example (EN). |
| packages/core/src/cli/init.ts | Implements pool normalization + merge behavior for CLI options into config. |
| packages/core/src/cli/commands.ts | Registers new --pool and --pool.* CLI options. |
| packages/core/LICENSE.md | Removes the yn third-party license block (potentially incorrect). |
| packages/core/AGENTS.md | Adds a note that E2E runs against built output and requires rebuilding core. |
| e2e/cli/index.test.ts | Adds E2E coverage for --pool shorthand being accepted by the CLI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--pool <type>shorthand for--pool.type--pool.maxWorkers,--pool.minWorkers, and--pool.execArgvmergeWithCLIOptionsto normalizepoolconfig (string to object) before merging--pool.execArgvoccurrences viacastArray--poolwith specific nested flagspool: 'forks'shorthand documentation and type definitions to Pool config pages--poolshorthand verificationpackages/core/AGENTS.mdregarding E2E build requirementsRelated Links
Checklist