fix(cli): exit with non-zero code when failed#898
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the CLI to exit with a non-zero exit code when the CLI fails to start, ensuring proper error reporting to the shell.
Changes:
- Added
process.exit(1)in the error handler ofrunCLI()function whensetupCommands()fails - Added an end-to-end test to verify that the CLI exits with code 1 when an invalid option is provided
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/cli/index.ts | Added process.exit(1) call in the catch block to exit with non-zero code when CLI setup fails |
| e2e/cli/index.test.ts | Added test case to verify CLI exits with code 1 when an unknown option is provided |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying rstest with
|
| Latest commit: |
3b7f0f3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a2f77c4a.rstest.pages.dev |
| Branch Preview URL: | https://fix-cli-exit-code.rstest.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
should exit with non-zero code when CLI start failed.
Related Links
Checklist