fix(core): lazy initialize StatusRenderer to prevent clearing early error messages#891
Merged
fix(core): lazy initialize StatusRenderer to prevent clearing early error messages#891
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where early error messages (e.g., missing Playwright browsers) were being cleared by the StatusRenderer before tests actually started. The fix lazily initializes the StatusRenderer only when the first test file starts, ensuring that error messages during initialization remain visible.
Changes:
- Modified
DefaultReporterconstructor to remove eager initialization ofStatusRenderer - Added
ensureStatusRenderer()private method to createStatusRendererlazily - Updated
onTestFileStart()to callensureStatusRenderer()before usingstatusRenderer
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
The actual reason Playwright’s error messages are not shown is that the reporter’s Lazy initialization of |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StatusRendererinDefaultReporterto avoid early stdout/stderr interceptionhuman input:
when playwright doesn't installed any browsers, the error message throw from
browser.launchwill be cleared by StatusRenderer, while no test file has started yet. so lazy initialize StatusRenderer to allow error message throw in Rsbuild initializing phase.Related Links
Checklist