Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the browser mode container UI to be served at the root path (/) instead of at /container.html, providing a cleaner and more intuitive URL structure for the browser test runner interface.
Changes:
- Modified middleware routing to serve container UI exclusively at
/instead of both/and/container.html - Updated browser navigation to target
/instead of/container.html - Improved user-facing log message from "Container page opened at..." to "Browser mode opened at..."
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/browser/src/hostController.ts | Updated middleware route check to only handle /, changed page navigation URL to root path, and improved log message wording |
| e2e/browser-mode/fixtures/basic/src/index.ts | Updated comment documentation to reflect the new root path serving behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
before
now
Related Links
Checklist