Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds stable data-testid attributes to browser-ui components for improved automation and agent testing capabilities, and documents the policy for maintaining these test IDs in the future.
Changes:
- Added
data-testidattributes to all interactive UI elements (buttons, inputs, tree nodes, headers) - Extended component props to support dynamic test identifiers (file paths, test case IDs, suite names)
- Documented the data-testid policy in AGENTS.md for future development
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/browser-ui/src/components/TestSuiteTitle.tsx | Added fullName prop and test IDs for suite titles and rerun buttons |
| packages/browser-ui/src/components/TestCaseTitle.tsx | Added caseId prop and test IDs for case titles and rerun buttons |
| packages/browser-ui/src/components/TestFileTitle.tsx | Added filePath prop and test IDs for file titles and action buttons |
| packages/browser-ui/src/components/TestFilesTree.tsx | Passed new props to title components and added test IDs for tree and project titles |
| packages/browser-ui/src/components/TestFilesHeader.tsx | Added test IDs to header, search input, and action buttons |
| packages/browser-ui/src/components/SidebarHeader.tsx | Added test IDs to header and theme toggle button |
| packages/browser-ui/src/components/PreviewHeader.tsx | Added test IDs to header and action buttons |
| packages/browser-ui/AGENTS.md | Added comprehensive documentation about data-testid policy and guidelines |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-testidhooks for browser-ui interactionsdata-testidinstruction to AGENTS.mdRelated Links
Checklist