Merged
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new Vue test fixture package for end-to-end testing, located at e2e/projects/fixtures/packages/client-vue/. The purpose appears to be related to fixing an rspack context issue on Windows based on the title, though the changes shown are primarily about adding a new test fixture structure.
Changes:
- Added a new client-vue fixture package with Vue 3 and Rsbuild configuration
- Configured test setup with @vue/test-utils and happy-dom environment
- Updated pnpm-lock.yaml with new dependencies for the Vue fixture
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Added dependency entries for the new client-vue fixture package |
| e2e/projects/fixtures/packages/client-vue/package.json | Package configuration with Vue dependencies and build scripts |
| e2e/projects/fixtures/packages/client-vue/tsconfig.json | TypeScript configuration for Vue with JSX and ESM support |
| e2e/projects/fixtures/packages/client-vue/rsbuild.config.ts | Rsbuild configuration with Vue plugin |
| e2e/projects/fixtures/packages/client-vue/rstest.config.ts | Test configuration extending rsbuild config with happy-dom environment |
| e2e/projects/fixtures/packages/client-vue/src/index.js | Vue app entry point |
| e2e/projects/fixtures/packages/client-vue/src/App.vue | Vue single file component with template, script, and styles |
| e2e/projects/fixtures/packages/client-vue/test/index.test.ts | Test file for the Vue component |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a Windows path issue when running Rstest test Vue projects in a monorepo.
On Windows,
process.cwd()returns paths in native format (using backslashes\,eg.C:\Users\Admin\xxx). Passing this path directly to the Rspack context, and then to vue-loader, works as expected.However, after Rstest applies path normalization, the path passed to the Rspack context is converted (
/, eg.C:/Users/Admin/xxx), which then leads to unexpected behavior when handled by vue-loader.Although this issue appears to be related to vue-loader’s path compatibility, we chose to preserve native Windows paths when passing them to the Rspack context, ensuring better compatibility with the majority of loaders when running on Windows.
Related Links
fix #865
Checklist