Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes the tree-kill logic for killing child processes in e2e tests by moving it from individual test files into the Cli class constructor. This ensures consistent process cleanup across all tests, particularly important on Windows where child processes may not be killed by default.
Changes:
- Centralized tree-kill logic in the Cli class by overriding the kill method
- Simplified test file by removing redundant tree-kill code and using the centralized implementation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| e2e/scripts/index.ts | Added tree-kill import and overrode the exec.kill method to automatically handle killing the entire process tree with fallback to original kill method |
| e2e/watch/restart.test.ts | Removed manual tree-kill logic and direct import, now uses the centralized kill method from Cli class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use tree-kill to kill e2e child process.
Related Links
Checklist