fix(types): loosen reporter type to support older versions#855
Merged
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request loosens the reporters type definition to support backward compatibility with older versions of @rstest/core (>=0.7.7). The changes allow adapters to work with different versions of the core package that may have had different reporter type definitions.
Key Changes:
- Introduced
LooseRstestConfigtype that replaces the strictReportertype withanyfor the reporters field - Updated
ExtendConfigandExtendConfigFnto use the new loosened type - Added peer dependency constraints for
@rstest/core(>=0.7.7) in adapter packages
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/types/config.ts | Introduces LooseRstestConfig type with relaxed reporter typing and updates dependent types |
| packages/adapter-rslib/package.json | Adds minimum version constraint for @rstest/core peer dependency |
| packages/adapter-rsbuild/package.json | Adds minimum version constraint for @rstest/core peer dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use loosen reporter type to support older versions.
Related Links
Checklist