Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in browser mode where the presence of src/index.ts in a project causes Rsbuild to auto-detect it as the default entry point, interfering with rstest's browser test runner. The fix ensures rstest's entry configuration takes highest priority by using modifyEnvironmentConfig with order: 'post' and explicitly overwriting the entry after merging configurations.
Key changes:
- Modified the plugin API call structure to use object form with
handlerandorder: 'post' - Entry configuration now explicitly overwrites after merge to prevent Rsbuild auto-detection
- Added regression test fixture with
src/index.tsin thebasice2e test suite
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/browser/src/hostController.ts | Restructured modifyEnvironmentConfig call to use order: 'post' and explicitly overwrite entry config after merge to ensure rstest's entry has highest priority |
| e2e/browser-mode/fixtures/basic/src/index.ts | Added test fixture file to verify the fix works when src/index.ts exists in project |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/index.ts(Rsbuild auto-detects it as default entry)modifyEnvironmentConfigwithorder: 'post'to ensure rstest's entry config has highest prioritysource.entryafter merge instead of relying onmergeEnvironmentConfigsrc/index.tsinbasicfixture to prevent regressionRelated Links
Checklist