Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes snapshot tests to normalize pnpm global store paths, making snapshots OS/host independent. The default path-serializer doesn't handle pnpm's global store structure, which varies across different systems.
Key Changes:
- Added custom snapshot serializer that wraps the existing
path-serializer - Implemented regex pattern to normalize pnpm global store paths to
<ROOT>/node_modules/<PNPM_INNER>/...format - Enabled additional path normalization features (
replaceHomeDir,replacePnpmInner,replaceTmpDir,transformWin32Path)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
It looks like some Rstest test cases are unstable on Windows with Node.js 20. I’ll create a PR to investigate and try to fix this. 😭 |
Collaborator
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stabilizes CI e2e runs without changing normal (isolated) behavior.
Changes
Files