feat: support show assertion calls when test timeout#753
Merged
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances timeout error messages to display the number of completed expect assertions when a test times out, providing better debugging information to developers.
Key Changes
- Modified the timeout error message to include assertion count information: "(completed N expect assertions)" or "(no expect assertions completed)"
- Moved timeout wrapping from test registration time to execution time to access runtime assertion counts
- Added
stackTraceErroras a required field onTestCasetype to preserve correct stack traces pointing to test definitions
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/types/testSuite.ts | Added required stackTraceError field to TestCase type to store stack trace at test registration |
| packages/core/src/runtime/runner/task.ts | Enhanced wrapTimeout to accept getAssertionCalls callback and include assertion count in timeout messages |
| packages/core/src/runtime/runner/runtime.ts | Removed early timeout wrapping and instead stores stackTraceError at test registration |
| packages/core/src/runtime/runner/runner.ts | Moved timeout wrapping to test execution time with assertion count tracking |
| e2e/test-api/timeout.test.ts | Updated test expectations to verify new timeout message format with assertion information |
| e2e/test-api/fixtures/timeout.test.ts | Changed to use local expect from context instead of global import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
support show assertion calls when test timeout.
before:
after:
Related Links
Checklist