fix: fixed font color when use background color#750
Merged
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes terminal font color readability issues by introducing a bgColor helper function that automatically applies appropriate contrasting text colors (white for dark backgrounds like red/black, dark for light backgrounds) when using background colors. This ensures consistent and readable output across different terminal themes.
Key Changes
- Created a centralized
bgColorhelper function that applies both background colors and appropriate contrasting foreground colors - Replaced direct
color.bgRed()andcolor.bgYellow()calls with the new helper - Ensures all status labels (FAIL, RUNS) are consistently bolded with proper contrast
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/core/src/utils/helper.ts | Added new bgColor helper function with BackgroundColor type definition to centralize color contrast logic |
| packages/core/src/reporter/summary.ts | Updated FAIL status label to use bgColor helper for proper text contrast |
| packages/core/src/reporter/statusRenderer.ts | Updated RUNS status label to use bgColor helper for proper text contrast |
| packages/core/src/core/listTests.ts | Updated FAIL status label to use bgColor helper for proper text contrast |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix font color in different terminal when use background color.
Related Links
Checklist