Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a flaky end-to-end test case that was causing CI failures. The test was checking signal handling behavior (SIGTERM, SIGINT, exit events) when signal listeners are present in the test environment. The removal is clean and complete, eliminating both the test file and its associated fixture.
- Removes flaky
signalListener.test.tstest that was failing in CI - Removes associated fixture file
fixtures/signalListener.test.ts - No orphaned references or files remain
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e/runner/test/signalListener.test.ts | Removes flaky test case that validated signal exit behavior with signal listeners |
| e2e/runner/test/fixtures/signalListener.test.ts | Removes the test fixture that set up signal listeners for the deleted test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remove flaky signalListener case
https://github.com/web-infra-dev/rstest/actions/runs/20061404350/job/57539029532
Related Links
Checklist