fix(vscode): should compute range correctly with chinese characters#733
Merged
fix(vscode): should compute range correctly with chinese characters#733
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the VSCode extension where range/position calculations were incorrect when source code contained multi-byte UTF-8 characters (such as Chinese characters). The SWC parser returns byte offsets, but the previous implementation incorrectly treated them as character offsets, causing misalignment when multi-byte characters were present.
Key Changes:
- Modified
spanToRangefunction to convert SWC's byte offsets to character indices using Buffer operations - Added defensive programming with
Math.max(0, ...)and optional chaining for edge cases - Added comprehensive test coverage with a test file containing Chinese characters
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/vscode/src/parserTest.ts | Implements byte-to-character conversion using Buffer to correctly handle multi-byte UTF-8 characters when calculating ranges |
| packages/vscode/tests/unit/test.txt | Test fixture containing a long string of Chinese characters to trigger the multi-byte character bug |
| packages/vscode/tests/unit/parse.test.ts | New test case that verifies range calculation works correctly with multi-byte characters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix wrong position when code with chinese characters.
Related Links
Checklist