fix: should handle circular reference in error object correctly#728
Merged
fix: should handle circular reference in error object correctly#728
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug where error objects with circular references would cause serialization failures during test execution. The fix removes the problematic spread operator and JSON.stringify operations that couldn't handle circular references.
Key Changes
- Removed spread operator (
...error) that was copying all enumerable properties including circular references - Removed JSON.stringify logic for
actualandexpectedproperties that would throw on circular references - Explicitly set only the required
fullStackproperty instead of spreading the entire error object
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/runtime/util.ts | Fixed error formatting to explicitly extract properties instead of spreading, preventing circular reference issues |
| e2e/test-api/fixtures/circularReference.test.ts | Added test fixture with circular reference between class instances to verify the fix |
| e2e/test-api/edgeCase.test.ts | Added E2E test case to ensure circular references in error objects are handled correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
should handle circular reference in error object correctly.
before:
after:
Related Links
fix #726
Checklist