fix: should get project's tsconfigPath correctly#687
Merged
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where relative tsconfigPath values in project configurations were not being resolved correctly relative to the project root, causing incorrect path resolution (e.g., getting rstest/tests/tsconfig.json instead of the expected rstest/packages/core/tests/tsconfig.json).
- Adds path resolution logic for project-level
tsconfigPathconfiguration - Updates the core package config to demonstrate the fix with a relative path
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/core/rstest.ts | Adds logic to resolve relative tsconfigPath to absolute paths based on project root |
| packages/core/rstest.config.ts | Adds tsconfigPath configuration using a relative path to demonstrate the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: should get project's tsconfigPath correctly.
expect get
rstest/packages/core/tests/tsconfig.json, but gotrstest/tests/tsconfig.jsonRelated Links
Checklist