Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ecosystem CI workflow by simplifying it to use reusable GitHub Actions and creating a legacy backup. The changes consolidate the ecosystem CI logic by delegating to shared actions from the rstack-ecosystem-ci repository instead of maintaining inline implementation.
- Replaced inline workflow logic with calls to reusable actions from
rspack-contrib/rstack-ecosystem-ci - Created a legacy backup file (
ecosystem-ci-legacy.yml) preserving the original implementation - Updated checkout action from v5 to v4 and removed pnpm installation steps
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| .github/workflows/ecosystem-ci.yml | Refactored to use reusable actions and simplified job structure |
| .github/workflows/ecosystem-ci-legacy.yml | New file preserving the original ecosystem CI implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: Dispatch ecosystem CI | ||
| runs-on: ubuntu-latest | ||
| if: github.repository == 'web-infra-dev/rstest' && github.event_name != 'workflow_dispatch' && needs.changes.outputs.changed == 'true' | ||
| if: github.repository == 'web-infra-dev/rstets' && github.event_name == 'workflow_dispatch' |
There was a problem hiding this comment.
Typo in repository name: 'rstets' should be 'rstest' to match the actual repository name used elsewhere in the codebase.
| name: Run Ecosystem CI | ||
| github-token: ${{ secrets.REPO_RSTEST_ECO_CI_GITHUB_TOKEN_NEXT }} | ||
| ecosystem-owner: web-infra-dev | ||
| ecosystem-repo: rstets |
There was a problem hiding this comment.
Typo in repository name: 'rstets' should be 'rstest' to match the actual repository name used elsewhere in the codebase.
| github-token: ${{ secrets.REPO_RSTEST_ECO_CI_GITHUB_TOKEN_NEXT }} | ||
| ecosystem-owner: web-infra-dev | ||
| ecosystem-repo: rstets | ||
| workflow-file: rstets-ecosystem-ci-selected.yml |
There was a problem hiding this comment.
Typo in workflow file name: 'rstets' should be 'rstest' to match the correct repository name.
| ecosystem-owner: web-infra-dev | ||
| ecosystem-repo: rstets | ||
| workflow-file: rstets-ecosystem-ci-selected.yml | ||
| client-payload: '{"ref":"${{ github.event.inputs.branch }}","repo":"web-infra-dev/rstets","suite":"-","suiteRefType":"precoded","suiteRef":"precoded"}' |
There was a problem hiding this comment.
Typo in repository name within client-payload: 'rstets' should be 'rstest' to match the actual repository name.
| needs: changes | ||
| runs-on: ubuntu-latest | ||
| if: github.repository == 'web-infra-dev/rstest' && github.event_name == 'workflow_dispatch' | ||
| if: github.repository == 'web-infra-dev/rstets' && github.event_name != 'workflow_dispatch' && needs.changes.outputs.changed == 'true' |
There was a problem hiding this comment.
Typo in repository name: 'rstets' should be 'rstest' to match the actual repository name used elsewhere in the codebase.
| }) | ||
| github-token: ${{ secrets.REPO_RSTEST_ECO_CI_GITHUB_TOKEN_NEXT }} | ||
| ecosystem-owner: web-infra-dev | ||
| ecosystem-repo: rstets |
There was a problem hiding this comment.
Typo in repository name: 'rstets' should be 'rstest' to match the actual repository name used elsewhere in the codebase.
| github-token: ${{ secrets.REPO_RSTEST_ECO_CI_GITHUB_TOKEN_NEXT }} | ||
| ecosystem-owner: web-infra-dev | ||
| ecosystem-repo: rstets | ||
| workflow-file: rstets-ecosystem-ci-from-commit.yml |
There was a problem hiding this comment.
Typo in workflow file name: 'rstets' should be 'rstest' to match the correct repository name.
| ecosystem-owner: web-infra-dev | ||
| ecosystem-repo: rstets | ||
| workflow-file: rstets-ecosystem-ci-from-commit.yml | ||
| client-payload: '{"commitSHA":"${{ github.sha }}","updateComment":true,"repo":"web-infra-dev/rstets","suite":"-","suiteRefType":"precoded","suiteRef":"precoded"}' |
There was a problem hiding this comment.
Typo in repository name within client-payload: 'rstets' should be 'rstest' to match the actual repository name.
Summary
use https://github.com/rspack-contrib/rstack-ecosystem-ci and we could check the status https://rstack-ecosystem-ci.netlify.app/ in the future.
the legacy workflow is still reserved, i'll delete it after ensure the new workflow works well.
Related Links
Checklist