Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how the build start time is tracked for performance metrics. Instead of capturing buildStart inside the run function, it is now passed as a parameter, allowing accurate build time measurement in watch mode by capturing the timestamp when the build compilation starts.
- Moved
buildStartfrom being initialized insiderunto being an optional parameter - Added logic to capture
buildStartinonBeforeDevCompileand pass it torunin watch mode - Reset
buildStarttoundefinedafter each test run to prevent reuse
Comments suppressed due to low confidence (5)
packages/core/src/core/runTests.ts:345
- The
runAllcallback does not passbuildStart, which will cause it to default toDate.now()at the time of the call. This makes the build time calculation inaccurate since no actual build occurs during this manual run. Consider documenting this behavior or passingbuildStart: testStartto ensurebuildTimereflects zero or near-zero when no build occurred.
await run({ mode: 'all' });
packages/core/src/core/runTests.ts:361
- The
runWithTestNamePatterncallback does not passbuildStart, which will cause it to default toDate.now()at the time of the call. This makes the build time calculation inaccurate since no actual build occurs during this manual run. Consider passingbuildStart: testStartor documenting that build time will be near-zero for these manual reruns.
await run();
packages/core/src/core/runTests.ts:396
- The
runWithFileFilterscallback does not passbuildStart, which will cause it to default toDate.now()at the time of the call. This makes the build time calculation inaccurate since no actual build occurs during this manual run. Consider passingbuildStart: testStartor documenting that build time will be near-zero for these manual reruns.
await run({ fileFilters: entries });
packages/core/src/core/runTests.ts:417
- The
runFailedTestscallback does not passbuildStart, which will cause it to default toDate.now()at the time of the call. This makes the build time calculation inaccurate since no actual build occurs during this manual run. Consider passingbuildStart: testStartor documenting that build time will be near-zero for these manual reruns.
await run({ fileFilters: failedTests, mode: 'all' });
packages/core/src/core/runTests.ts:439
- The
updateSnapshotcallback does not passbuildStart, which will cause it to default toDate.now()at the time of the call. This makes the build time calculation inaccurate since no actual build occurs during this manual run. Consider passingbuildStart: testStartor documenting that build time will be near-zero for these manual reruns.
await run({ fileFilters: failedTests });
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix inaccurate build time in watch mode.
Related Links
Checklist