chore(workflow): disable fail-fast option in e2e test#622
Merged
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Disable fail-fast in the e2e GitHub Actions workflow so that other matrix jobs continue running even if one fails due to flaky timeouts.
- Add fail-fast: false to the job strategy
- Applied within the test workflow matrix configuration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.github/workflows/test.yml
Outdated
Comment on lines
+76
to
+79
| # run ut in macOS, as SWC cases will fail in Ubuntu CI | ||
| os: [macos-14, windows-latest] | ||
| node_version: [18, 20, 22, 24] | ||
| fail-fast: false |
There was a problem hiding this comment.
fail-fast is placed under matrix, which does not affect job cancellation behavior. This adds a matrix variable instead of disabling the fast-fail strategy. Move fail-fast up one level to jobs.<job_id>.strategy (sibling to matrix), e.g.: strategy: fail-fast: false and then strategy: matrix: ....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disable fail-fast option in e2e test due to unstable timeouts for some tests.
Related Links
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idstrategyfail-fast
Checklist