Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the VSCode extension configuration by adding an icon, cleaning up distribution artifacts, and resolving dependency hoisting issues for the vsce packaging tool.
Key changes:
- Added icon support with automatic download fallback
- Updated workspace configuration to hoist @secretlint dependencies for vsce compatibility
- Improved documentation table formatting and added new configuration option
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Added hoistPattern for @secretlint dependencies to satisfy vsce requirements |
| packages/vscode/package.json | Added icon field and preinstall script to download icon if missing |
| packages/vscode/README.md | Reformatted configuration table and added logLevel setting documentation |
| packages/vscode/.vscodeignore | Added new file to specify which files to include in the extension package |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| }, | ||
| "scripts": { | ||
| "preinstall": "[ -f icon.png ] || curl https://assets.rspack.rs/rstest/rspress-logo-512x512.png --output icon.png", |
There was a problem hiding this comment.
The preinstall script uses shell syntax that may not work on Windows. Consider using a cross-platform solution like downloading the icon through a Node.js script or including the icon file directly in the repository.
| "preinstall": "[ -f icon.png ] || curl https://assets.rspack.rs/rstest/rspress-logo-512x512.png --output icon.png", | |
| "preinstall": "node ./scripts/download-icon.js", |
Summary
vscehappyRelated Links
Checklist