Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a race condition in the VS Code extension where the initial test file scan could complete after test pattern configuration changes, potentially repopulating test files that should be excluded by updated glob patterns.
- Extracts the async
scanAllTestFilesoperation from the constructor into a separateinitialize()method - Updates the
activate()function to await the initialization before returning the extension instance
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9aoy
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes a race where the VS Code extension finished its initial test-file scan after the test suite reconfigured
rstest.testFileGlobPattern. previously the constructor kicked offscanAllTestFileswithout awaiting it, so late completions could repopulate foo.test.ts even when only*.spec.*patterns were allowed.Related Links
Checklist