Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR makes the type property optional in the RstestPoolOptions type definition. The change allows the pool type to be undefined, providing more flexibility in configuration.
- Updated TypeScript type definition to make
pool.typeoptional - Synchronized documentation in both English and Chinese to reflect the type change
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/types/config.ts | Makes the type property optional in RstestPoolOptions type definition |
| website/docs/en/config/test/pool.mdx | Updates English documentation to show optional type property |
| website/docs/zh/config/test/pool.mdx | Updates Chinese documentation to show optional type property |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| export type RstestPoolOptions = { | ||
| /** Pool used to run tests in. */ | ||
| type: 'fork'; | ||
| type?: 'fork'; |
There was a problem hiding this comment.
The documentation shows type?: 'fork' but the actual type definition uses RstestPoolType which is defined as 'forks' (plural). The documentation should match the actual type: type?: 'forks' or explain the discrepancy.
| export type RstestPoolOptions = { | ||
| /** 用于运行测试的线程池 */ | ||
| type: 'fork'; | ||
| type?: 'fork'; |
There was a problem hiding this comment.
The documentation shows type?: 'fork' but the actual type definition uses RstestPoolType which is defined as 'forks' (plural). The documentation should match the actual type: type?: 'forks' or explain the discrepancy.
Summary
chore(type): make
pool.typeoptional.Related Links
Checklist