feat: allow set coverage thresholds as negative number#570
Merged
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for negative coverage thresholds, which represent the maximum number of uncovered entities allowed instead of minimum percentage coverage. This provides an alternative way to specify coverage requirements.
Key Changes:
- Added documentation explaining negative threshold functionality in both English and Chinese
- Updated type definitions to support the negative threshold feature
- Modified test coverage examples and expectations to demonstrate the new functionality
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/config/test/coverage.mdx | Added Chinese documentation for negative threshold feature with examples |
| website/docs/en/config/test/coverage.mdx | Added English documentation for negative threshold feature with examples |
| packages/core/src/types/coverage.ts | Added Totals type import and CoverageSummaryTotals export to support implementation |
| e2e/test-coverage/index.test.ts | Updated test expectations to reflect new coverage behavior and added negative threshold test |
| e2e/test-coverage/fixtures/test/string.test.ts | Removed test coverage to create scenario for negative threshold testing |
| e2e/test-coverage/fixtures/rstest.thresholds.config.ts | Added negative lines threshold configuration for testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow set coverage thresholds as negative number. Thresholds specified as a negative number represent the maximum number of uncovered entities allowed.
Related Links
Checklist