feat: support coverage.reportsDirectory option#557
Merged
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a configurable coverage.reportsDirectory option to allow users to specify where coverage reports should be generated, defaulting to './coverage'.
- Adds
reportsDirectoryfield to coverage configuration types - Updates the Istanbul coverage provider to use the configured directory
- Implements proper path resolution for both relative and absolute paths
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/coverage-istanbul/src/provider.ts | Updates coverage provider to use configurable reports directory and imports proper type |
| packages/core/src/types/coverage.ts | Adds reportsDirectory option to coverage types and imports proper CoverageMap type |
| packages/core/src/config.ts | Adds default reportsDirectory value and path resolution logic |
| packages/core/package.json | Adds istanbul-lib-coverage types dependency |
| e2e/test-coverage/index.test.ts | Adds test for custom reportsDirectory functionality |
| e2e/test-coverage/fixtures/rstest.reportsDirectory.config.ts | Test configuration for custom reports directory |
| e2e/projects/fixtures/rstest.coverage.config.ts | Coverage configuration for projects test |
| e2e/projects/fixtures/package.json | Package dependencies for projects test |
| e2e/projects/coverage.test.ts | Test coverage functionality in projects context |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
support
coverage.reportsDirectoryoption.Related Links
Checklist