fix: should avoid outputs conflict in projects#515
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes output directory conflicts when running tests with multiple projects by ensuring each project gets its own separate output directory.
- Updates the basic plugin to use project-specific output directories when multiple projects are configured
- Adds comprehensive test coverage for multi-project configuration handling
- Includes end-to-end test fixture for client package testing
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/core/plugins/basic.ts | Modifies output path logic to create separate directories per project when multiple projects exist |
| packages/core/tests/core/rsbuild.test.ts | Adds new test case verifying correct rspack config generation with multiple projects |
| packages/core/tests/core/snapshots/rsbuild.test.ts.snap | Snapshot data for the new multi-project test case |
| e2e/projects/fixtures/packages/client/test/index.test.ts | Simple test fixture for end-to-end testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }, | ||
| projects: [ | ||
| { | ||
| name: 'test', |
There was a problem hiding this comment.
[nitpick] Both projects in the test have the same base name 'test', which may not accurately reflect real-world scenarios where projects typically have distinct names. Consider using different names like 'client' and 'server' to better test the output path generation logic.
Summary
should avoid outputs conflict in projects.
Related Links
Checklist