Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the manualMockRoot configuration for projects where it was incorrectly using the global context root path instead of the project-specific root path. The fix ensures that manual mocks are resolved relative to each project's own directory structure rather than the workspace root.
- Updates the mock root path resolution to use project-specific
rootPathinstead of globalcontext.rootPath - Extracts
testEnvironmentandrootPathfrom the project configuration for cleaner access - Adds test coverage to verify the manual mocking functionality works correctly with the fix
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/core/plugins/basic.ts | Fixed manualMockRoot path resolution and extracted project-specific variables |
| e2e/projects/fixtures/packages/node/test/mockFs.test.ts | Added test case for filesystem mocking functionality |
| e2e/projects/fixtures/packages/node/src/readSomeFile.ts | Added utility function for reading files in test scenarios |
| e2e/projects/fixtures/packages/node/mocks/fs.js | Added manual mock for Node.js fs module using memfs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix
manualMockRootin projects, useproject.rootPathinstead ofcontext.rootPath.Related Links
Checklist