Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents potential errors by avoiding repeated killing of an execution process in the test cleanup. The change adds a safety check to ensure the process is only killed if it hasn't already been terminated.
- Adds a guard condition to prevent double-killing of the CLI execution process
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| onTestFinished(() => { | ||
| cli.exec.kill(); | ||
| !cli.exec.killed && cli.exec.kill(); |
There was a problem hiding this comment.
Consider using optional chaining for better null safety: cli.exec?.killed === false && cli.exec?.kill(). This prevents potential errors if cli.exec is undefined or null.
Suggested change
| !cli.exec.killed && cli.exec.kill(); | |
| cli.exec?.killed === false && cli.exec?.kill(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test: avoid repeated killing of exec
Related Links
Checklist