Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents log clearing in debug mode to improve debugging experience. The change adds a condition to skip clearing the console when debug mode is enabled, allowing developers to retain console output for troubleshooting.
- Imports
isDebugutility function to check debug mode status - Adds conditional logic to skip console clearing when in debug mode
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -171,7 +176,9 @@ export async function runTests(context: RstestContext): Promise<void> { | |||
| } | |||
| }; | |||
| const clearLogs = () => { | |||
There was a problem hiding this comment.
[nitpick] Consider adding a comment explaining why logs are preserved in debug mode, as this behavior change may not be immediately obvious to other developers.
Suggested change
| const clearLogs = () => { | |
| const clearLogs = () => { | |
| // In debug mode, we intentionally preserve logs to aid debugging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
should not clearLogs in debug mode.
Related Links
Checklist