Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the @rstest/core package to simplify its public API by removing the separate node exports and consolidating all types and exports through the main entry point. This change eliminates the need for consumers to import from different paths and clarifies the module structure.
Key changes:
- Consolidation of all types and exports to the main index.ts entry point
- Removal of the separate node.ts module and its corresponding exports
- Simplification of package.json exports configuration
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/reporter/rstest.customReporterConfig.ts | Updates import statement to use main entry point instead of /node path |
| packages/core/src/node.ts | Removes the entire node.ts file that previously exported types |
| packages/core/src/index.ts | Adds CLI export and consolidates all type exports from the removed node module |
| packages/core/rslib.config.ts | Updates build configuration to use single index entry point |
| packages/core/package.json | Simplifies exports configuration to use only the main entry point |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| import type { RstestConfig } from './types'; | ||
|
|
||
| export { runCLI } from './cli'; | ||
|
|
There was a problem hiding this comment.
The runCLI export appears to be adding a new public API surface. Since this is a refactoring PR focused on consolidating exports, consider whether exposing CLI functionality as part of the main API is intentional or if it should remain internal.
Summary
Remove
nodeexports, only exports alltypesandexportsfrom main entry.Restructures the public API surface of the
@rstest/corepackage to simplify imports and clarify module boundaries. The main entry point has been consolidated toindex.ts, and types and exports have been unified to reduce confusion for consumers.import type { Reporter, TestFileInfo, TestFileResult, TestResult, - } from '@rstest/core/node'; + } from '@rstest/core';Related Links
Checklist