feat: support filter by filename regex pattern via p shortcut#470
Merged
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for filtering test files by filename using regex patterns via a new p keyboard shortcut in the CLI. This feature complements the existing test name pattern filtering (t shortcut) by allowing users to narrow down which test files are included in the test run.
- Adds
fileFiltersproperty toRstestContextfor storing filename filter patterns - Implements
runWithFileFiltersfunction to handle file filtering during watch mode - Introduces new
pshortcut for entering filename regex patterns in the CLI
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/core/src/types/core.ts |
Adds optional fileFilters property to RstestContext type |
packages/core/src/core/context.ts |
Updates context creation to accept and store fileFilters |
packages/core/src/core/index.ts |
Passes fileFilters from CLI arguments to context creation |
packages/core/src/core/runTests.ts |
Implements file filtering logic and runWithFileFilters function |
packages/core/src/core/listTests.ts |
Updates to use fileFilters from context instead of parameter |
packages/core/src/core/cliShortcuts.ts |
Adds p shortcut and refactors input prompting logic |
website/docs/en/guide/basic/cli.mdx |
Documents the new p shortcut in English documentation |
website/docs/zh/guide/basic/cli.mdx |
Documents the new p shortcut in Chinese documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
support filter by filename regex pattern via
pshortcut.Related Links
Checklist