Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates Rslint, a type-aware linting tool, into the project's development workflow. The integration adds a new linter configuration and updates documentation to include Rslint as part of the Rstack toolchain.
Key Changes
- Added Rslint configuration file with TypeScript-specific linting rules
- Updated documentation to include Rslint in the list of Rstack tools
- Applied code style fixes addressing various linting issues throughout the codebase
Reviewed Changes
Copilot reviewed 35 out of 36 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rslint.jsonc | New configuration file for Rslint with TypeScript ESLint rules |
| package.json | Added Rslint dependency and integrated into lint script |
| biome.json | Updated Biome schema version |
| Multiple .ts files | Code style improvements including unnecessary assertions removal and array type syntax |
| Documentation files | Added Rslint to toolchain listings in both English and Chinese docs |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
tests/scripts/index.ts
Outdated
| public stderr = ''; | ||
| private stdoutListeners: Array<() => void> = []; | ||
| private stderrListeners: Array<() => void> = []; | ||
| // private stderrListeners: Array<() => void> = []; |
There was a problem hiding this comment.
Consider removing commented-out code entirely rather than leaving it in the codebase. If this is temporarily disabled for a specific reason, add a TODO comment explaining why.
Suggested change
| // private stderrListeners: Array<() => void> = []; |
9aoy
approved these changes
Aug 7, 2025
Collaborator
|
🦀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rslint yes.
Related Links
Checklist