Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a "require is not defined" error when using mock fake timers with Node.js modules by enabling the require shim in the rstest bundle configuration.
- Adds
requireshim configuration to enable CommonJS require in ES modules - Adds test case to verify fake timers work with
node:timersmodule
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/rslib.config.ts | Enables require shim in ESM bundle configuration |
| tests/fakeTimers/index.test.ts | Adds test case using require('node:timers') to verify the fix |
| const cb = rstest.fn(); | ||
| const cb1 = rstest.fn(); | ||
| setTimeout(cb, 100); | ||
| setTimeout(cb1, 200); |
There was a problem hiding this comment.
[nitpick] Using require() in a TypeScript test file is inconsistent with the ES module pattern used elsewhere. Consider using import { setTimeout } from 'node:timers' instead, or add a comment explaining why require() is specifically needed for this test case.
Suggested change
| setTimeout(cb1, 200); | |
| const cb = rstest.fn(); | |
| const cb1 = rstest.fn(); | |
| nodeSetTimeout(cb, 100); | |
| nodeSetTimeout(cb1, 200); |
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shim
requirein rstest bundle. fixrequire is not definederror when fake timers.Related Links
Checklist