Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR implements prebundling of runtime dependencies to improve application startup performance. The changes move several packages from runtime dependencies to bundled dependencies and update the build configuration accordingly.
- Updated rslib configuration to bundle specific runtime dependencies using the
bundledPackagesoption - Moved testing-related dependencies from
dependenciestodevDependenciesin package.json - Added license information for newly bundled packages
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/core/rslib.config.ts | Updated DTS bundle configuration to specify packages for prebundling |
| packages/core/package.json | Moved chai and vitest packages from runtime to dev dependencies |
| packages/core/LICENSE | Added license notices for bundled packages |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
packages/core/package.json
Outdated
| "tinypool": "^1.1.1" | ||
| }, | ||
| "devDependencies": { | ||
| "chai": "^5.2.1", |
There was a problem hiding this comment.
Moving 'chai' from dependencies to devDependencies may break runtime functionality if the package is used at runtime. Verify that 'chai' is only used in tests or development environments.
packages/core/package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "chai": "^5.2.1", | ||
| "@types/chai": "^5.2.2", |
There was a problem hiding this comment.
Moving '@types/chai' from dependencies to devDependencies may cause TypeScript compilation issues if these types are exposed in the public API. Verify that these types are not part of the public interface.
| "@types/chai": "^5.2.2", | |
| "tinypool": "^1.1.1", | |
| "@types/chai": "^5.2.2" | |
| }, | |
| "devDependencies": { | |
| "chai": "^5.2.1", |
| '@vitest/expect', | ||
| '@vitest/snapshot', | ||
| '@vitest/utils', | ||
| '@vitest/spy', |
There was a problem hiding this comment.
The package '@vitest/spy' is listed in bundledPackages but was not moved from dependencies to devDependencies in package.json. This inconsistency should be addressed to ensure proper dependency management.
Summary
Prebundle runtime dependencies to speed up runtime.
before:
after:
Related Links
Checklist